Fix timestamps #4

New Issue

kirsle · 2023-02-10T00:25:28Z

kirsle commented

2023-02-10 00:25:28 +00:00

Timestamps are currently broken in several ways:

They are mostly sent by the server side, which is in UTC time zone and look wrong on the front-end.
Some server messages (like presence events on join/leave room) don't have timestamps at all and the front-end interprets these to be Dec 31 0000 5:07 PM.

Timestamps are probably best removed from the server protocol and made up client-side as messages come in. The server-side logs already have their own timestamps in case timing of events needs to be debugged from the server side.

Timestamps are currently broken in several ways: * They are mostly sent by the server side, which is in UTC time zone and look wrong on the front-end. * Some server messages (like presence events on join/leave room) don't have timestamps at all and the front-end interprets these to be Dec 31 0000 5:07 PM. Timestamps are probably best removed from the server protocol and made up client-side as messages come in. The server-side logs already have their own timestamps in case timing of events needs to be debugged from the server side.

kirsle added the

bug

label 2023-02-10 00:25:28 +00:00

kirsle commented

2023-02-12 00:06:47 +00:00

Poster

Fixed by b966f85ecc (front-end timestamps) and 15ebc42bd3 (server side removal).

Fixed by b966f85ecc5124732056bd53a243efcd1588c78b (front-end timestamps) and 15ebc42bd3ec77bc97b8a897044b01a29304a294 (server side removal).

kirsle closed this issue

2023-02-12 00:06:47 +00:00

Sign in to join this conversation.