Muting your mic and then changing audio/video source might unmute your audio #27

New Issue

kirsle · 2023-07-23T05:07:07Z

kirsle commented

2023-07-23 05:07:07 +00:00

Repro steps:

Go on video as normal
Mute your mic
Go in the chat settings and toggle your video/audio devices to use different devices.
Your mic appears to be muted and shows as muted to your watchers, but they might hear your audio regardless

Root cause seems to be: changing an audio/video source re-sets up the video while requesting specific device IDs to use, and replaces the streams of your WebRTC watchers, and this always defaults to a non-muted microphone.

The fix should be: after all that happens, to check the front-end mic mute setting and reapply the mute on the new stream.

Repro steps: 1. Go on video as normal 2. Mute your mic 3. Go in the chat settings and toggle your video/audio devices to use different devices. 4. Your mic appears to be muted and shows as muted to your watchers, but they might hear your audio regardless Root cause seems to be: changing an audio/video source re-sets up the video while requesting specific device IDs to use, and replaces the streams of your WebRTC watchers, and this always defaults to a non-muted microphone. The fix should be: _after_ all that happens, to check the front-end mic mute setting and reapply the mute on the new stream.

kirsle added the

enhancement

label 2023-07-23 05:07:07 +00:00

kirsle closed this issue

2023-08-12 17:25:36 +00:00

Sign in to join this conversation.