Misc Papercuts #20

New Issue

kirsle · 2023-06-28T21:39:49Z

kirsle commented

2023-06-28 21:39:49 +00:00

Various small bugs/fixes that don't warrant whole tickets for each:

DMs on the left drawer could show profile pictures next to them to easier distinguish who's who
When you have your cam set to "auto-open viewers cams" and you open someone else's first, and that person then opens yours up, their video will 'reload' because the action of them opening yours makes your browser (re)open theirs (even tho it's already open).
- May be related to a muting issue: if you muted their cam before they opened yours (and you reloaded theirs) the mute button state might be out of sync.
- Easy fix should be don't double-open already connected cams / flush out front-end state better when cams are closed.
Similar muting bug on your own camera: go on cam, mute your mic, turn your cam off, then go on again. The frontend thinks your cam is muted but since it's a brand new video, it was not muted and the frontend is out of sync. Should be resolved by: when turning off your cam, reset all the front-end state around the mute button etc.
For deployments that use JWT token authentication, the chat home page gives an Authentication Denied error if the user reloads the page and doesn't have the JWT token. A better UX may be to configure a default landing page, e.g. if someone reloads instead of the auth error you redirect them to the site's chat entry page (or to the page that directly puts them back in the chat room if they're still logged in on your site) so that reloading the page results in a nicer experience.

Video flags refactor + new features

Currently we have several video flags that go into the Who List and me updates: videoActive, videoMutual and videoMutualOpen and NSFW and these could be consolidated down into a single field with a bitmask, e.g.

Flag	Binary value (bitmask)
Video active	0b00000001
Mutual required	0b00000010
Mutual auto-open	0b00000100
Video explicit	0b00001000
Muted upstream	0b00010000

And have room for additional flags like:

User is currently speaking (detect audio levels and highlight cams on the frontend)

Various small bugs/fixes that don't warrant whole tickets for each: * [x] DMs on the left drawer could show profile pictures next to them to easier distinguish who's who * [ ] When you have your cam set to "auto-open viewers cams" and you open someone else's first, and that person then opens yours up, their video will 'reload' because the action of them opening yours makes your browser (re)open theirs (even tho it's already open). * May be related to a muting issue: if you muted their cam before they opened yours (and you reloaded theirs) the mute button state might be out of sync. * Easy fix should be don't double-open already connected cams / flush out front-end state better when cams are closed. * [x] Similar muting bug on your own camera: go on cam, mute your mic, turn your cam off, then go on again. The frontend thinks your cam is muted but since it's a brand new video, it was not muted and the frontend is out of sync. Should be resolved by: when turning off your cam, reset all the front-end state around the mute button etc. * [x] For deployments that use JWT token authentication, the chat home page gives an Authentication Denied error if the user reloads the page and doesn't have the JWT token. A better UX may be to configure a default landing page, e.g. if someone reloads instead of the auth error you redirect them to the site's chat entry page (or to the page that directly puts them back in the chat room if they're still logged in on your site) so that reloading the page results in a nicer experience. ### Video flags refactor + new features Currently we have several video flags that go into the Who List and `me` updates: `videoActive`, `videoMutual` and `videoMutualOpen` and `NSFW` and these could be consolidated down into a single field with a bitmask, e.g. | Flag | Binary value (bitmask) | |-----------------|------------------------| | Video active | 0b00000001 | | Mutual required | 0b00000010 | | Mutual auto-open| 0b00000100 | | Video explicit | 0b00001000 | | Muted upstream | 0b00010000 | And have room for additional flags like: * User is currently speaking (detect audio levels and highlight cams on the frontend)

kirsle added the

enhancement

label 2023-06-28 21:39:50 +00:00

Sign in to join this conversation.