Super Mario 64 OpenGL port for PC. Mirror of
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

40 lines
1.3 KiB

#include "gd_types.h"
* @file bad_declarations.h
* Match incorrect type promotion for two declared functions.
* There is an issue with the compiled code for these function calls in files
* outside of the files in which they were defined: instead of passing f32's,
* the caller passes f64's.
* The only possible reason I can come up with for this behavior is that
* goddard only declared (not prototyped) his functions in the headers,
* and didn't include the header in the function's defining .c file.
* (Even IDO 5.3 cares about illegal promotion of types!) This results in
* default argument promotion, which is incorrect in this case.
* Since that's an awful practice to emulate, include this file (first!) to prevent
* the proper prototypes of these functions from being seen by files with the
* the incorrectly compiled calls.
#ifndef AVOID_UB
/* shape_helper.h */
extern struct ObjFace *make_face_with_colour();
/* should be: make_face_with_colour(f32, f32, f32) */
/* old_menu.h */
extern struct ObjLabel *make_label();
/* should be: make_label(struct ObjValPtrs *, char *, s32, f32, f32, f32) */
#endif /* !AVOID_UB */